List:Commits« Previous MessageNext Message »
From:Martin Hansson Date:March 24 2008 10:40am
Subject:Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068
View as plain text  
Hi Ingo,
I approve this patch. Just some thoughts below. I let you decide whether 
to act upon them or not.

Best Regards
/Martin

Ingo Struewing wrote:
>   
>   get_all_tables() from information schema assumes that it opens
>   one table at a time. If it cannot be opened, and the error is
>   ER_NO_SUCH_TABLE, it assumes that no table needs to be closed.
>   
IMHO the above information would be helpful if it were included in the 
comment to get_all_tables() as well.
> +    /*
> +      If the error happened on a MERGE child, clear the parents TABLE
>   
I'd say "parent's TABLE" here...


Thread
bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Ingo Struewing18 Mar
  • Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Martin Hansson24 Mar
    • Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Ingo Strüwing25 Mar
      • Re: bk commit into 5.1 tree (istruewing:1.2565) BUG#35068Martin Hansson28 Mar