Chuck,
Chuck Bell wrote:
> Rafal,
>
> I will try and give you all the information I can discern.
>
> After running this several times I discovered it doesn't always crash in the
> same place in the test -- just the code. I agree that there is something
> funny going on.
>
> So I implemented the "when all else fails on Windows, rebuild from scratch."
> Which improved the problems as it manages to execute correctly most of the
> time, but still crashes in the same manner once in a while.
>
> Very strange. I am sorry, I cannot explain this behavior. I will try and
> work on it a bit more next week.
>
It is worrying that you still observe the crashes. I analysed clean-up of
Backup_restore_ctx and related objects and couldn't find any obvious errors. I
think it is impossible to trace this issue down until we can reproduce it. I run
backup tests several times on my machine and they always pass.
> I will not hold up the review for this. If we find that PB finds the
> problems we can go back and look at it. Do you agree?
>
Yes, if possible and if you agree I think we should push this one finally - so
many other changes are waiting for that.
Rafal