List:Commits« Previous MessageNext Message »
From:Ingo Strüwing Date:March 12 2008 3:12pm
Subject:Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259
View as plain text  
Hi Sergei,

Sergei Golubchik, 12.03.2008 15:30:
...
>      Is it difficult to support
>    global debug_sync ?

Yes. The actions are stored in an array referenced by THD. Every thread
can request different actions for the same sync point.

We could have a global array too. And add actions to it when SET GLOBAL
is given. But then each sync point would need to search in two arrays. A
local action would supersede the global action. But if there is none, it
would search for a global one.

Another problem is the semantics of resetting the global actions. CLEAR
or RESET is used to remove an action. Now one could define that CLEAR
removes the local action if present or the global action if the local
one is not present. RESET clears everything, local and global? Or global
only if no local action is present?

> 
> 2. Anyway, the error message is wrong. A generic mistake - you cannot use
>    "global variable" as a parameter, as it breaks localized error messages,

Hm. I was fooled by other applications of this error message, like:
"BASE TABLE" or "TRIGGERNAME".

>    as in "SESSION.debug_sync ist nicht global variable". For this
>    particular case there is ER_LOCAL_VARIABLE:
...

Ok. That's better of course.

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140
Thread
bk commit into 6.0 tree (istruewing:1.2569) WL#4259Ingo Struewing12 Mar
  • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Ingo Strüwing12 Mar
  • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Sergei Golubchik12 Mar
    • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Ingo Strüwing12 Mar
      • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Sergei Golubchik17 Mar
        • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Ingo Strüwing17 Mar
          • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Sergei Golubchik17 Mar
            • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Ingo Strüwing18 Mar
  • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Rafal Somla20 Mar
    • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Ingo Strüwing10 Apr
      • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Rafal Somla14 Apr
        • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Ingo Strüwing16 Apr
          • Re: bk commit into 6.0 tree (istruewing:1.2569) WL#4259Rafal Somla16 Apr