List:Commits« Previous MessageNext Message »
From:Jonathan Perkin Date:March 5 2008 9:52am
Subject:Re: bk commit into 5.1 tree (jperkin:1.2645) BUG#31736
View as plain text  
* On 2008-03-04 at 22:58 GMT, Kent Boortz wrote:

> Timothy Smith <tim@stripped> writes:
>
> > On Wed, Dec 19, 2007 at 01:24:50PM +0000, Jonathan Perkin wrote:
> >
> > > diff -Nrup a/libmysqld/Makefile.am b/libmysqld/Makefile.am
> > > --- a/libmysqld/Makefile.am	2007-08-31 00:23:07 +01:00
> > > +++ b/libmysqld/Makefile.am	2007-12-19 10:26:20 +00:00
> > > @@ -21,13 +21,14 @@ MYSQLDATAdir =		$(localstatedir)
> > >  MYSQLSHAREdir =		$(pkgdatadir)
> > >  MYSQLBASEdir=		$(prefix)
> > >  MYSQLLIBdir=            $(libdir)
> > > +pkgplugindir =		$(libdir)/@PACKAGE@/plugin
> >
> > Should this use $(pkglibdir) instead of $(libdir)/@PACKAGE@?
> 
> I second this, if no problem when you test it, please use
> $(pkglibdir). Would mean our build scripts needs no change.

Yeh, I fixed this in http://lists.mysql.com/commits/40484

> The change looks good!

Thanks,

-- 
Jonathan Perkin, Senior Production Engineer
MySQL UK Ltd, www.mysql.com
Thread
bk commit into 5.1 tree (jperkin:1.2645) BUG#31736Jonathan Perkin19 Dec
  • Re: bk commit into 5.1 tree (jperkin:1.2645) BUG#31736Timothy Smith19 Dec
    • Re: bk commit into 5.1 tree (jperkin:1.2645) BUG#31736Jonathan Perkin2 Jan
      • Re: bk commit into 5.1 tree (jperkin:1.2645) BUG#31736Timothy Smith4 Jan
    • Re: bk commit into 5.1 tree (jperkin:1.2645) BUG#31736Kent Boortz4 Mar
      • Re: bk commit into 5.1 tree (jperkin:1.2645) BUG#31736Jonathan Perkin5 Mar