List:Commits« Previous MessageNext Message »
From:Mats Kindahl Date:March 5 2008 8:20am
Subject:Re: bk commit into 5.1 tree (aelkin:1.2551) BUG#28780
View as plain text  
Morning Andrei!

Andrei Elkin wrote:
> Mats, good morning.
>
>   
[snip]

>>>>> +connection master;
>>>>> +sync_slave_with_master;
>>>>>         
>>>>>           
>>>> What's the purpose of this? Isn't that already done in the
> master-slave.inc?
>>>>
>>>>     
>>>>         
>>> Sorry, do not undestand your wondering.
>>>   
>>>       
>> Why do you do a "connection master; sync_slave_with_master;" ?
>>     
>
> Aha.
> Actually, a good question. I seem to have added them "automatically".
> The pair is not needed at all because testing is entirely on the slave
> side.
>
> Removed.
>
> Wrt "Isn't that already done in the master-slave.inc" - i have not
> found any syncronization...
> And indeed that is the reason of my "automatic" behaviour at the first
> place.
> If that lack of synchronization is the real fact, i suggest to fix the
> macro you are wondering if it has it.
>   

Well... if it turns out that you need to add it, the risk is big that 
everybody else needs it, so then the master-slave.inc file should be 
fixed. If it turns out that you need these two lines, I suggest that you 
fix the include file instead.

Just my few cents,
Mats Kindahl

>
> regards,
>
> Andrei
>
>   


-- 
Mats Kindahl
Lead Software Developer
Replication Team
MySQL AB, www.mysql.com


Thread
bk commit into 5.1 tree (aelkin:1.2551) BUG#28780Andrei Elkin4 Mar
  • Re: bk commit into 5.1 tree (aelkin:1.2551) BUG#28780Mats Kindahl4 Mar
    • Re: bk commit into 5.1 tree (aelkin:1.2551) BUG#28780Andrei Elkin4 Mar
      • Re: bk commit into 5.1 tree (aelkin:1.2551) BUG#28780Mats Kindahl5 Mar
        • Re: bk commit into 5.1 tree (aelkin:1.2551) BUG#28780Andrei Elkin5 Mar
          • Re: bk commit into 5.1 tree (aelkin:1.2551) BUG#28780Mats Kindahl5 Mar