List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:March 4 2008 1:50pm
Subject:Re: bk commit into 5.0 tree (bar:1.2578) BUG#23097
View as plain text  
Bar,

On 04.03.2008, at 14:13, bar@stripped wrote:

> Below is the list of changes that have just been committed into a  
> local
> 5.0 repository of bar.  When bar does a push these changes
> will be propagated to the main repository and, within 24 hours after  
> the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
>
> ChangeSet@stripped, 2008-03-04 16:13:08+04:00, bar@stripped +5 -0
>  Bug#23097 mysql can't insert korean on mysql prompt.
>  Problem: libedit is a very pure-ASCII oriented library,
>  and it is not aware of extended (0x80..0xFF) or even multi-byte
>  characters. It considered such characters as non-printable
>  and didn't allow to input them.
>  Fix: make libedit think that all bytes >= 0x80 are printable.


Question :
readline ( _rl_init_eightbit() in cmd-line-utils/readline/nls.c)  
appears to be setting the locale to whatever is specified in the  
environment.
Instead of trying to re-define the ctype.h macros why don't you do  
exactly the same for libedit ? This will imho make the problem go away  
as well (as I can imagine the system locale would be capable of  
processing korean correctly). Or are there any implications on the  
rest of the mysql client code ?

Best Regards,
Joro
-- 
Georgi Kodinov, Team Lead, Server General Team
MySQL AB, Plovdiv, Bulgaria, www.mysql.com
Office: +359 32 634 397 Mobile: +359 887 700 566 Skype: georgekodinov

Are you MySQL certified?  www.mysql.com/certification

Thread
bk commit into 5.0 tree (bar:1.2578) BUG#23097bar4 Mar
  • Re: bk commit into 5.0 tree (bar:1.2578) BUG#23097Georgi Kodinov4 Mar
    • Re: bk commit into 5.0 tree (bar:1.2578) BUG#23097Alexander Barkov4 Mar