List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:February 29 2008 9:18am
Subject:Re: bk commit into 5.1 tree (anozdrin:1.2552) BUG#31947
View as plain text  
Hi!

On Feb 29, Alexander Nozdrin wrote:
> ChangeSet@stripped, 2008-02-29 12:10:51+03:00, anozdrin@quad. +1 -0
>   Fix for Bug#31947: Declare with a reserved word succeeded.
>   
>   READ_ONLY token was accidentally placed into wrong place
>   ('ident' rule). The proper place is in the 'keyword' rule.
>   
>   The manual should be re-generated after this patch, because
>   the manual depends on the keyword rule.
> 
>   sql/sql_yacc.yy@stripped, 2008-02-29 12:10:50+03:00, anozdrin@quad. +1 -6
>     Move READ_ONLY token to the 'keyword' rule.

move it to keyword_sp, not keyword.
and ok to push
 
> diff -Nrup a/sql/sql_yacc.yy b/sql/sql_yacc.yy
> --- a/sql/sql_yacc.yy	2008-02-29 02:22:48 +03:00
> +++ b/sql/sql_yacc.yy	2008-02-29 12:10:50 +03:00
> @@ -10312,12 +10312,6 @@ TEXT_STRING_filesystem:
>  
>  ident:
>            IDENT_sys    { $$=$1; }
> -        | READ_ONLY_SYM
> -          {
> -            THD *thd= YYTHD;
> -            $$.str= thd->strmake("read_only",9);
> -            $$.length= 9;
> -          }
>          | keyword
>            {
>              THD *thd= YYTHD;
> @@ -10416,6 +10410,7 @@ keyword:
>          | PARTITION_SYM         {}
>          | PORT_SYM              {}
>          | PREPARE_SYM           {}
> +        | READ_ONLY_SYM         {}
>          | REMOVE_SYM            {}
>          | REPAIR                {}
>          | RESET_SYM             {}
> 
> -- 
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe:    http://lists.mysql.com/commits?unsub=1
> 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer/Server Architect
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.1 tree (anozdrin:1.2552) BUG#31947Alexander Nozdrin29 Feb
  • Re: bk commit into 5.1 tree (anozdrin:1.2552) BUG#31947Sergei Golubchik29 Feb