RE: bk commit into 6.0 tree (vvaintroub:1.2822) BUG#34085

[Vladislav Vaintroub]

> -----Original Message-----
> From: Kevin Lewis [mailto:klewis@stripped]
> Sent: Monday, February 25, 2008 4:01 PM
> To: vvaintroub@stripped; commits@stripped
> Subject: RE: bk commit into 6.0 tree (vvaintroub:1.2822) BUG#34085
> 
> Vlad,
> 
> Why did you take out
> 
> -	if (storageHandler)
> 
> 3 places in ha_falcon.cpp?

To translate my previous reply to plain English :)

Why did I remove the "if" from StorageInterface::updateRecordScavengeFloor.

if (storageHandler)
		storageHandler->setRecordScavengeFloor(falcon_record_scavenge_floor);


If storageHandler == NULL, this is an indicator that storage engine plugin is not loaded (
either  because of --skip_falcon or because of insane parameters leading to failing memory
allocation)

This implies that Falcon specific variables (like falcon_record_scavenge_floor) are not
visible. Therefore it is also not is not possible to
change them, thus  StorageInterface::updateRecordScavengeFloor is never called. Actually ,
no StorageInterface member functions will ever be called, after  falcon_init returns an
error.

Vlad