List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:February 20 2008 2:00pm
Subject:Re: bk commit into 5.0 tree (kaa:1.2607) BUG#33834
View as plain text  
Hi!

On Feb 20, Alexey Kopytov wrote:
> Sergei Golubchik wrote:
> >On Feb 19, Sergei Golubchik wrote:
> >>On Feb 18, Alexey Kopytov wrote:
> >>>ChangeSet@stripped, 2008-02-18 16:41:34+03:00, kaa@kaamos.(none) +3 -0
> >>>  Fix for bug #33834: FRAC_SECOND: Applicability not clear in 
> >>>                      documentation
> >>>  
> >>>  While the manual mentions FRAC_SECOND only for the TIMESTAMPADD()
> >>>  function, it was also possible to use FRAC_SECOND with
> >>>  DATE_ADD(), DATE_SUB() and +/- INTERVAL.
> >>>  
> >>>  Fixed the parser to match the manual, i.e. using FRAC_SECOND for
> >>>  anything other than TIMESTAMPADD()/TIMESTAMPDIFF() now produces a
> >>>  syntax error.
> >
> >Additionally, please add a warning in the parser that FRAC_SECOND, is
> >deprecated and will be removed in, say, 6.2. With a comment explaining
> >why (see peter's comment in the bugreport).
> > 
> 
> Just to make sure, shoult it be an SQL warning, or just a source comment?

WARN_DEPRECATED()
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer/Server Architect
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.0 tree (kaa:1.2607) BUG#33834Alexey Kopytov18 Feb
  • Re: bk commit into 5.0 tree (kaa:1.2607) BUG#33834Sergei Golubchik19 Feb
    • Re: bk commit into 5.0 tree (kaa:1.2607) BUG#33834Sergei Golubchik19 Feb
      • Re: bk commit into 5.0 tree (kaa:1.2607) BUG#33834Alexey Kopytov20 Feb
        • Re: bk commit into 5.0 tree (kaa:1.2607) BUG#33834Sergei Golubchik20 Feb
    • Re: bk commit into 5.0 tree (kaa:1.2607) BUG#33834Alexey Kopytov20 Feb