Re: bk commit into 5.0 tree (kaa:1.2607) BUG#33834

[Alexey Kopytov]

Hi Sergei,

Sergei Golubchik wrote:
> Hi!
> 
> On Feb 18, Alexey Kopytov wrote:
>> ChangeSet@stripped, 2008-02-18 16:41:34+03:00, kaa@kaamos.(none) +3 -0
>>   Fix for bug #33834: FRAC_SECOND: Applicability not clear in 
>>                       documentation
>>   
>>   While the manual mentions FRAC_SECOND only for the TIMESTAMPADD()
>>   function, it was also possible to use FRAC_SECOND with DATE_ADD(),
>>   DATE_SUB() and +/- INTERVAL.
>>   
>>   Fixed the parser to match the manual, i.e. using FRAC_SECOND for 
>>   anything other than TIMESTAMPADD()/TIMESTAMPDIFF() now produces a 
>>   syntax error.
>>
>> diff -Nrup a/sql/sql_yacc.yy b/sql/sql_yacc.yy
>> --- a/sql/sql_yacc.yy	2008-02-01 11:00:39 +03:00
>> +++ b/sql/sql_yacc.yy	2008-02-18 16:41:32 +03:00
>> @@ -442,7 +442,7 @@ Item* handle_sql2003_note184_exception(T
>>    enum Item_udftype udf_type;
>>    CHARSET_INFO *charset;
>>    thr_lock_type lock_type;
>> -  interval_type interval, interval_time_st;
>> +  interval_type interval, interval_time_st, interval_time_stamp;
> 
> why is that (why do you need to create another type for
> interval_time_stamp rule) ?
> 

Right, I don't. Will remove in the new patch.

Best regards,
Alexey.

>>    timestamp_type date_time_type;
>>    st_select_lex *select_lex;
>>    chooser_compare_func_creator boolfunc2creator;
> 
> Otherwise ok.
> 
> Regards / Mit vielen Grüssen,
> Sergei
> 


-- 
Alexey Kopytov, Software Developer
MySQL AB, www.mysql.com

Are you MySQL certified?  www.mysql.com/certification