Hi!
On Feb 18, Davi Arnaut wrote:
> ChangeSet@stripped, 2008-02-18 10:18:07-03:00, davi@stripped +4 -0
> Bug#34424 query_cache_debug.test leads to valgrind warnings
>
> The problem is that the per-thread debugging settings stack wasn't
> being deallocated before the thread termination, leaking the stack
> memory. The solution is to free the per-thread debugging settings
> stack once the thread finishes.
What's wrong with DBUG_POP() as a cleanup, why do you need a special
function for this ?
Note that it's ok to have a warning if DBUG_PUSH and DBUG_POP are not
paired, no need to fix that. The memory leak comes from DBUG_PUSH that
doesn't have a matching DBUG_POP. Using DBUG_POP as a cleanup seems
appropriate.
Regards / Mit vielen Grüssen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Developer/Server Architect
/_/ /_/\_, /___/\___\_\___/ MySQL GmbH, Dachauer Str. 37, D-80335 München
<___/ Geschäftsführer: Kaj Arnö - HRB
München 162140
