Initially i had SHOW STATUS; without a filter
in my test, where i checked the difference.
Added that LIKE in a very last moment and
didn't check the result indeed.
Difference for the result without the patch:
@@ -4344,9 +4344,9 @@
Variable_name Value
Handler_read_first 0
Handler_read_key 2
-Handler_read_next 0
+Handler_read_next 10
Handler_read_prev 0
Handler_read_rnd 0
-Handler_read_rnd_next 6
+Handler_read_rnd_next 7
DROP TABLE t1, t2;
Regards
HF
----- Original Message -----
From: "Timour Katchaounov" <timour@stripped>
To: <holyfoot@stripped>
Cc: <commits@stripped>
Sent: Saturday, February 16, 2008 4:38 PM
Subject: Re: bk commit into 5.0 tree (holyfoot:1.2584) BUG#32942
> Alexey,
>
> It is great that you added a test case, but you made a mistake
> in the SHOW STATUS clause.
>
> > +SELECT DISTINCT b FROM t1 LEFT JOIN t2 USING(a) WHERE c <= 3;
> > +SHOW STATUS LIKE 'Handler_read*';
>
> Here it must be:
> SHOW STATUS LIKE 'Handler_read%';
> as I suggested in my previous email. This mistakes means that you
> didn't verify at all the test result :(.
>
> <cut>
>
> Please fix the above mistake, then run the test both *with* and
> *without* your patch, compare the results, and verify what you get
> is consistent with what you expect from the fix. Also please send
> me both results.
>
> Timour
>
> --
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe: http://lists.mysql.com/commits?unsub=1
>
