Re: bk commit into 5.1 tree (anozdrin:1.2552) BUG#34337

[Konstantin Osipov]

* Alexander Nozdrin <alik@stripped> [08/02/15 12:26]:
> ChangeSet@stripped, 2008-02-15 12:01:11+03:00, anozdrin@quad. +3 -0
>   Fix for Bug#34337: Server crash when Altering a view using
>   a table name.

I think the actual problem is in fill_defined_view_parts().

It has the following code:

 if (!open_table(thd, &decoy, thd->mem_root, &not_used, OPEN_VIEW_NO_PARSE)
&&
      !decoy.view)
  {
    /* It's a table */
    return TRUE;
  }

But for some reason the code doesn't work as expected
and falls through to the privilege check with an incorrect
definer.

I believe the right fix should be to ensure
that fill_defined_view_parts returns an error
when we're trying to alter a table.

Thanks for working on this,

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY