Re: bk commit into 5.1 tree (kostja:1.2518) BUG#12713

[Sergei Golubchik]

Hi!

On Feb 07, konstantin@stripped wrote:
> ChangeSet@stripped, 2008-02-07 17:17:09+03:00, kostja@dipika.(none) +26 -0
>   A fix and a test case for Bug#12713 "Error in a stored function called from 
>   a SELECT doesn't cause ROLLBACK of statem".
>   
>   The idea of the fix is to ensure that we always commit the current
>   statement at the end of dispatch_command(). In order to not issue
>   redundant disc syncs, an optimization of the two-phase commit
>   protocol is implemented to bypass the two phase commit if
>   the transaction is read-only.

Very good!
Thank you.
Just one comment:

> +insert into t2 (a) values (1023);
> +do (f2(23));
> +Warnings:
> +Error	1062	Duplicate entry '23' for key 'a'
> +select * from t2;
> +a
> +23
> +1023

This looks like a bug, why 23 is in the table ?

Ok to push after fixing it.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer/Server Architect
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140