List:Commits« Previous MessageNext Message »
From:Mats Kindahl Date:February 14 2008 8:53am
Subject:bk commit into 5.1 tree (mkindahl:1.2552) BUG#24387
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of mkindahl.  When mkindahl does a push these changes
will be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-02-14 09:53:01+01:00, mkindahl@stripped +1 -0
  Fixes to try to handle valgrind warnings identical to those in
  BUG#24387, which is closed since long.

  sql/mysqld.cc@stripped, 2008-02-14 09:52:52+01:00, mkindahl@stripped +1 -1
    Moving my_thread_end() to before pthread_cond_broadcast() since
    it might cause other threads to start using resources that are
    about to be released, or tries to proceed assuming that the
    resources have already been released.

diff -Nrup a/sql/mysqld.cc b/sql/mysqld.cc
--- a/sql/mysqld.cc	2008-02-08 16:55:02 +01:00
+++ b/sql/mysqld.cc	2008-02-14 09:52:52 +01:00
@@ -1869,9 +1869,9 @@ bool one_thread_per_connection_end(THD *
 
   /* It's safe to broadcast outside a lock (COND... is not deleted here) */
   DBUG_PRINT("signal", ("Broadcasting COND_thread_count"));
+  my_thread_end();
   (void) pthread_cond_broadcast(&COND_thread_count);
 
-  my_thread_end();
   pthread_exit(0);
   DBUG_RETURN(0);                               // Impossible
 }
Thread
bk commit into 5.1 tree (mkindahl:1.2552) BUG#24387Mats Kindahl14 Feb