Tatjana Azundris Nurnberg <azundris@stripped> writes:
>>> diff -Nrup a/sql/sql_plugin.cc b/sql/sql_plugin.cc
>>> --- a/sql/sql_plugin.cc 2007-12-13 12:49:55 +01:00
>>> +++ b/sql/sql_plugin.cc 2008-01-07 02:47:54 +01:00
>>> @@ -1916,16 +1928,28 @@ static int check_func_long(THD *thd, str
>>> else
>>> *(long *)save= (long) getopt_ll_limit_value(tmp, &options,
> &fixed);
>>>
>>> - if (fixed)
>>> + if (*(long *)save != (long) tmp)
>>
>> why ?
>> in set_var.cc you use didn't change 'fixed' to 'save != tmp'.
I checked with Antony and streamlined that whole section; both
internal and plugin variables go through the same checks now,
saved a couple of lines too (rather unsurprisingly :).
>> and server built-in variables still
>> auto-correct invalid values even in strict mode.
>>
>> Wouldn't you avoid code duplication if you add thsi check to
>> throw_bounds_warning() ? (and use it in sql_plugin.cc, of course)
Done.
Please re-review.
thanks, and have a nice weekend,
-T-
--
Tatjana A. Nurnberg, Bugs Bunny * MySQL AB, http://www.mysql.de/ * EST
IRC: Azundris * Skype: azundris * MySQL-SIP: 4550 * eMail: azundris@stripped
.de: Firmensitz: MySQL GmbH, Radlkoferstr. 2, D-81373 Muenchen
Geschaeftsfuehrer: Hans von Bell, Kaj Arnoe - HRB Muenchen 162140
