Re: bk commit into 5.0 tree (davi:1.2570) BUG#33798

[Konstantin Osipov]

* Davi Arnaut <davi@stripped> [08/02/08 15:00]:
> >> @@ -2875,7 +2876,10 @@ const String *Item_param::query_val_str(
> >>  {
> >>    switch (state) {
> >>    case INT_VALUE:
> >> -    str->set(value.integer, &my_charset_bin);
> >> +    if (unsigned_flag)
> >> +      str->set((ulonglong) value.integer, &my_charset_bin);
> >> +    else
> >> +      str->set(value.integer, &my_charset_bin);
> > 
> > In other words, this change does not seem to be necessary.
> > 
> 
> Yes, it's necessary, otherwise we end-up with a wrong binlog. The
> integer to string conversion is different for unsigned and signed, take
> a look at String::set.

Right, sorry.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY