Re: bk commit into 5.1 tree (davi:1.2516) BUG#31891

[Sergei Golubchik]

Hi!

On Feb 07, Davi Arnaut wrote:
> Sergei Golubchik wrote:

> >> @@ -2041,7 +2041,7 @@ AC_CHECK_FUNCS(alarm bcmp bfill bmove bs
> >>    sighold sigset sigthreadmask port_create sleep \
> >>    snprintf socket stpcpy strcasecmp strerror strsignal strnlen strpbrk
> strstr \
> >>    strtol strtoll strtoul strtoull tell tempnam thr_setconcurrency vidattr
> \
> >> -  posix_fallocate)
> >> +  posix_fallocate backtrace backtrace_symbols backtrace_symbols_fd)
> > 
> > What's the point in checking for backtrace_symbols and
> > backtrace_symbols_fd if you never test the corresponding HAVE_ defines ?
> 
> Good point, I'll cover both under their respective HAVE_ defines.

Only if you think it's reasonable to expect a system where backtrace()
is present but for example backtrace_symbols_fd() is not.

Otherwise testing for backtrace() only is enough.

(and I think it's enough - see e.g. ncurses test - configure checks if
ncurses library is available, not if every function we use is
available).
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140