Re: bk commit into 5.1 tree (davi:1.2516) BUG#31891

[Davi Arnaut]

Sergei Golubchik wrote:
> Hi!
> 
> On Feb 04, Davi Arnaut wrote:
>> ChangeSet@stripped, 2008-02-04 10:05:06-02:00, davi@stripped +4 -0
>>   Bug#31891 Meaningful stack trace
>>   
>>   On crashes generate a user-friendly resolved and demangled stack
>>   trace when libc provides the necessary functions (newer libc on i386,
>>   x86_64, powerpc, ia64, alpha and s390). Otherwise print a numeric
>>   stack trace as before, relying on resolve_stack_dump utility.
> 
> Looks ok to me. One comment:
>  
>> diff -Nrup a/configure.in b/configure.in
>> --- a/configure.in	2008-02-01 08:50:16 -02:00
>> +++ b/configure.in	2008-02-04 10:05:04 -02:00
>> @@ -813,8 +813,8 @@ AC_CHECK_HEADERS(fcntl.h float.h floatin
>>   sys/timeb.h sys/types.h sys/un.h sys/vadvise.h sys/wait.h term.h \
>>   unistd.h utime.h sys/utime.h termio.h termios.h sched.h crypt.h alloca.h \
>>   sys/ioctl.h malloc.h sys/malloc.h sys/ipc.h sys/shm.h linux/config.h \
>> - sys/prctl.h \
>> - sys/resource.h sys/param.h port.h ieeefp.h)
>> + sys/prctl.h sys/resource.h sys/param.h port.h ieeefp.h \
>> + execinfo.h)
>>  
>>  AC_CHECK_HEADERS([xfs/xfs.h])
>>  
>> @@ -2041,7 +2041,7 @@ AC_CHECK_FUNCS(alarm bcmp bfill bmove bs
>>    sighold sigset sigthreadmask port_create sleep \
>>    snprintf socket stpcpy strcasecmp strerror strsignal strnlen strpbrk strstr \
>>    strtol strtoll strtoul strtoull tell tempnam thr_setconcurrency vidattr \
>> -  posix_fallocate)
>> +  posix_fallocate backtrace backtrace_symbols backtrace_symbols_fd)
> 
> What's the point in checking for backtrace_symbols and
> backtrace_symbols_fd if you never test the corresponding HAVE_ defines ?

Good point, I'll cover both under their respective HAVE_ defines.

Regards,

-- 
Davi Arnaut, Software Engineer
MySQL Inc, www.mysql.com

Are you MySQL certified?  www.mysql.com/certification