* Alexander Nozdrin <alik@stripped> [08/01/28 22:24]:
> ChangeSet@stripped, 2008-01-28 20:09:25+03:00, anozdrin@quad. +37 -0
> Fix for Bug#32538: View definition picks up character set,
> but not collation.
>
> The problem here was that text literals in a view were always
> dumped with character set introducer. That lead to loosing
> collation information.
>
> The fix is to dump character set introducer only if it was
> in the original query.
OK to push.
Nice idea.
Please explain in the changeset comment that the patch
is possible now because there
is no problem any more of loss of character set of string literals
in views -- after WL#4052 the view is dumped in the original
character set.
> +
> + inline bool is_cs_specified() const
> + {
> + return m_cs_specified;
> + }
> +
Please add a doxygen comment describing which situation this
method is expected to be called.
> + inline void set_cs_specified(bool cs_specified)
> + {
> + m_cs_specified= cs_specified;
> + }
> +
> +private:
> + bool m_cs_specified;
> };
>
--
-- Konstantin Osipov Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com The best DATABASE COMPANY in the GALAXY
