Re: bk commit into 5.1 tree (mattiasj:1.2518) BUG#34225

[Ingo Strüwing]

Hi Mattias,

mattiasj@stripped, 05.02.2008 16:01:
...
> ChangeSet@stripped, 2008-02-05 16:00:59+01:00, mattiasj@witty. +49 -0
>   Bug#34225: test suit parts uses /tmp-dir
>   
>   Since it used /tmp-dir, it continues to fail on the same server
>   until the /tmp-dir is cleaned. (Another problem was that it
>   uses DATA/INDEX DIR without checking for symlink, which is needed)
>   
>   
>   Solution:
>   Moved all DATA/INDEX DIR test to a new partition_basic_symlink.inc file
>   and use this for myisam and innodb, also requiring symlinks and
>   not_windows.
>   (i.e. removed DATA/INDEX DIR use from several tests)
> 
>   mysql-test/suite/parts/inc/partition_basic.inc@stripped, 2008-02-05 16:00:55+01:00,
> mattiasj@witty. +0 -45
>     Bug#34225: test suit parts uses /tmp-dir
>     
>     Removed the DATA/INDEX DIR, since the test is not dependent of it
>     (adding "--source include/have_symlink.inc" would have disabled it
>     on some of the pushbuild-machines)

I would say "... on some platforms". That's more general and probably
better understandable for a non-MySQL-employee developer.

...
> +++ b/mysql-test/suite/parts/inc/partition_basic_symlink.inc	2008-02-05 16:00:57
> +01:00
> @@ -0,0 +1,158 @@
> +################################################################################
> +# inc/partition_basic.inc                                                      #

This looks like a copy&paste error.

> +#                                                                              #
> +# Purpose:                                                                     #
> +#   Basic tests around create partitioned table with/without PRIMARY KEY and   #
> +#   /or UNIQUE INDEX                                                           #
> +#                                                                              #
> +#------------------------------------------------------------------------------#
> +# Original Author: mleich                                                      #

Oh. Thanks Matthias for helping Mattias. Or still copy&paste error?

> +# Original Date: 2006-03-05                                                    #

Probably copy&paste error.

...

I did not find any --replace_result. Don't you need it because you don't
have any SHOW CREATE TABLE _and_ use --disable_query_log when creating
the tables? If yes, I would prefer to see SHOW CREATE TABLE with
DATA/INDEX DIRECTORY for some partitioned tables. It should be tested too.

Otherwise still approved.

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140