List:Commits« Previous MessageNext Message »
From:Rafal Somla Date:February 5 2008 9:39am
Subject:Re: bk commit into 6.0 tree (cbell:1.2784) BUG#33172
View as plain text  
Chuck,

I'm not disappointed any more :P I see the problem with creating COND outside of 
open_schema_table() function and agree that it can't be done that way. Thus your 
decision to ignore that requirement was justified.

Sorry for hasty comment...

Rafal

Chuck Bell wrote:
>> b) implement suggested change of open_schema_table() 
>> signature (you can ignore the optional suggestion if you 
>> don't like it).
> 
> Can't do this -- see below.
>
(cut)
>> I would extend open_schema_table() with COND* parameter - 
>> that would make it much more general as one could open a I_S 
>> table with arbitrary select condition. 
>> The usage would be then:
>>
>> COND *cond;
>>
>> <build condition cond>
>>
>> TABLE *t= open_schema_table(thd, st, cond);
> 
> You cannot do this. In order to build the COND* tree you need the table. The
> method open_schema_table() opens the table. So it has to be done in 2 steps.
> 

Thread
bk commit into 6.0 tree (cbell:1.2784) BUG#33172cbell30 Jan
  • Re: bk commit into 6.0 tree (cbell:1.2784) BUG#33172Rafal Somla30 Jan
    • Re: bk commit into 6.0 tree (cbell:1.2784) BUG#33172Alexander Nozdrin31 Jan
      • RE: bk commit into 6.0 tree (cbell:1.2784) BUG#33172Chuck Bell31 Jan
    • RE: bk commit into 6.0 tree (cbell:1.2784) BUG#33172Chuck Bell31 Jan
      • Re: bk commit into 6.0 tree (cbell:1.2784) BUG#33172Rafal Somla5 Feb