List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:February 1 2008 3:36pm
Subject:Re: bk commit into 5.1 tree (thek:1.2681) BUG#27145
View as plain text  
Hi!

On Feb 01, kpettersson@stripped wrote:
> ChangeSet@stripped, 2008-02-01 15:44:26+01:00, thek@adventure.(none) +16 -0
>   Bug#27145 EXTRA_ACL troubles

Thanks.
Ok to push after fixing a couple of small issues, see below:

> diff -Nrup a/mysql-test/t/grant4.test b/mysql-test/t/grant4.test
> --- /dev/null	Wed Dec 31 16:00:00 196900
> +++ b/mysql-test/t/grant4.test	2008-02-01 15:44:23 +01:00
> @@ -0,0 +1,141 @@
///
> +connection con1;
> +use mysqltest_db1;
> +--echo ** Connect as restricted user mysqltest_u1.
> +--echo ** SELECT FROM INFORMATION_SCHEMA.STATISTICS will succeed because any
> privileges will do (authentication is enough).

I don't see where you've added a reference to the bug.
Please add:

#
# this result is wrong. reported as bug#34104
#

> +SELECT * FROM INFORMATION_SCHEMA.STATISTICS WHERE table_name='t5';
...
> diff -Nrup a/sql/sql_parse.cc b/sql/sql_parse.cc
> --- a/sql/sql_parse.cc	2007-12-10 16:43:23 +01:00
> +++ b/sql/sql_parse.cc	2008-02-01 15:44:22 +01:00
> @@ -2668,11 +2667,53 @@ end_with_restore_list:
....
> +      } else

indentation

> +      {
> +        ulong save_priv;
> +        if (check_access(thd, TABLE_ACLS, first_table->db,
> +                         &save_priv, FALSE, FALSE,
> +                         test(first_table->schema_table)))

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.1 tree (thek:1.2681) BUG#27145kpettersson1 Feb
  • Re: bk commit into 5.1 tree (thek:1.2681) BUG#27145Sergei Golubchik1 Feb