List:Commits« Previous MessageNext Message »
From:Vladislav Vaintroub Date:February 1 2008 10:56am
Subject:RE: bk commit into 5.0 tree (iggy:1.2573) BUG#26243
View as plain text  
Hi Iggy,
Minor comment:
> +#if !defined(__WIN__) && !defined(_WIN32) && !defined(_WIN64)


FWIW, _WIN32 alone is enough -  predefined by the Microsoft compiler on both 32 and 64 bit
(http://msdn2.microsoft.com/en-us/library/b0084kay.aspx) And other windows compilers like
Borland, MinGW and icc define _WIN32 it too, probably to be able to use windows.h from
the SDK

On some reasons, probably historical, server code prefers  __WIN__  and I believe it is
most appropriate here (even though there is a bug against its usage that will probably be
Won't Fixed)

Vlad


> -----Original Message-----
> From: Ignacio Galarza [mailto:iggy@stripped]
> Sent: Friday, February 01, 2008 1:18 AM
> To: commits@stripped


Thread
bk commit into 5.0 tree (iggy:1.2573) BUG#26243Ignacio Galarza1 Feb
  • RE: bk commit into 5.0 tree (iggy:1.2573) BUG#26243Vladislav Vaintroub1 Feb
  • Re: bk commit into 5.0 tree (iggy:1.2573) BUG#26243Jim Winstead5 Feb