List:Commits« Previous MessageNext Message »
From:rburnett Date:January 29 2008 4:41pm
Subject:Connector/NET commit: r1152 - in branches/5.1: . Driver/Source
View as plain text  
Modified:
   branches/5.1/CHANGES
   branches/5.1/Driver/Source/Connection.cs
Log:
- Fixed problem where connection state reported through the state change handler was not
  showing Open (bug #34082).
This was a result of the code we added to internally set the state but not send out
notifications.  There was a line of code that short circuited the SetState method if the 
old and new state was the same.  The problem is that the Open method sets the state to
open with no broadcast and then sets the state to open with broadcast.  The short
circuits keeps the second call from notifying clients of the change.

Modified: branches/5.1/CHANGES
===================================================================
--- branches/5.1/CHANGES	2008-01-24 16:31:45 UTC (rev 1151)
+++ branches/5.1/CHANGES	2008-01-29 15:41:41 UTC (rev 1152)
@@ -3,6 +3,8 @@
     a second parameter with the same name as the first (bug #33347)
   - Fixed long standing problem with compression over a network.  It's now fast again.
(bug #27865)    
   - Fixed nant compilation problem on mono (bug #33508)
+  - Fixed problem where connection state reported through the state change handler was
not
+    showing Open (bug #34082)   
    
 Version 5.1.4 - 11/12/2007
   - Fixed issue where column name metadata was not using the charset given on the
connection string

Modified: branches/5.1/Driver/Source/Connection.cs
===================================================================
--- branches/5.1/Driver/Source/Connection.cs	2008-01-24 16:31:45 UTC (rev 1151)
+++ branches/5.1/Driver/Source/Connection.cs	2008-01-29 15:41:41 UTC (rev 1152)
@@ -404,7 +404,7 @@
 
         internal void SetState(ConnectionState newConnectionState, bool broadcast)
         {
-            if (newConnectionState == connectionState)
+            if (newConnectionState == connectionState && !broadcast)
                 return;
             ConnectionState oldConnectionState = connectionState;
             connectionState = newConnectionState;

Thread
Connector/NET commit: r1152 - in branches/5.1: . Driver/Sourcerburnett29 Jan 2008