From: Date: January 16 2008 3:56pm
Subject: Re: bk commit into 5.1 tree (kostja:1.2659)
List-Archive: http://lists.mysql.com/commits/41034
Message-Id: <01E64D5F-CC4F-4E24-AB7D-73E78A6737A2@mysql.com>
MIME-Version: 1.0 (Apple Message framework v753)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Content-Transfer-Encoding: 7bit

Hi!

On Jan 16, 2008, at 3:44 PM, konstantin@stripped wrote:
[skip]
> ChangeSet@stripped, 2008-01-16 16:44:07+03:00, kostja@dipika.(none)  
> +1 -0
>   A minor cleanup.
>
>   sql/sql_insert.cc@stripped, 2008-01-16 16:44:04+03:00, kostja@dipika. 
> (none) +0 -1
>     Remove a redundant call to my_error() -- in case of out of  
> memory, the error
>     is reported already by operator new (Delayed_inserts inherits  
> from ilink).
>
> diff -Nrup a/sql/sql_insert.cc b/sql/sql_insert.cc
> --- a/sql/sql_insert.cc	2007-12-14 16:01:11 +03:00
> +++ b/sql/sql_insert.cc	2008-01-16 16:44:04 +03:00
> @@ -1862,7 +1862,6 @@ bool delayed_get_table(THD *thd, TABLE_L
>      {
>        if (!(di= new Delayed_insert()))
>        {
> -	my_error(ER_OUTOFMEMORY,MYF(0),sizeof(Delayed_insert));
>          thd->fatal_error();
>          goto end_create;
>        }

The patch is OK because my_malloc called (from new) with parameters  
to report bugs.

[skip]

-- 
    __  ___     ___ ____  __
   /  |/  /_ __/ __/ __ \/ /    Mr. Oleksandr Byelkin <sanja@stripped>
  / /|_/ / // /\ \/ /_/ / /__   MySQL AB, Full-Time Developer
/_/  /_/\_, /___/\___\_\___/   Lugansk, Ukraine
        <___/   www.mysql.com