bk commit into 5.1 tree (jonas:1.2529) BUG#33793

[jonas]

Below is the list of changes that have just been committed into a local
5.1 repository of jonas. When jonas does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2008-01-11 09:20:16+01:00, jonas@stripped +4 -0
  ndb - bug#33793
    dont assume that page is "all empty"
    only as gci is acked, as release_gci might not have processed it yet

  storage/ndb/src/kernel/blocks/ERROR_codes.txt@stripped, 2008-01-11 09:20:14+01:00,
jonas@stripped +1 -1
    new error codes

  storage/ndb/src/kernel/blocks/suma/Suma.cpp@stripped, 2008-01-11 09:20:14+01:00,
jonas@stripped +15 -1
    dont assume that page is "all empty"
    only as gci is acked, as release_gci might not have processed it yet
    

  storage/ndb/test/ndbapi/test_event.cpp@stripped, 2008-01-11 09:20:14+01:00,
jonas@stripped +61 -0
    testcase

  storage/ndb/test/run-test/daily-basic-tests.txt@stripped, 2008-01-11 09:20:14+01:00,
jonas@stripped +4 -0
    testcase

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jonas
# Host:	perch.ndb.mysql.com
# Root:	/home/jonas/src/51-telco-gca

--- 1.82/storage/ndb/test/run-test/daily-basic-tests.txt	2008-01-11 09:20:19 +01:00
+++ 1.83/storage/ndb/test/run-test/daily-basic-tests.txt	2008-01-11 09:20:19 +01:00
@@ -942,3 +942,7 @@
 cmd: test_event
 args: -n Bug31701 T1
 
+max-time: 300
+cmd: test_event
+args: -n Bug33793 T1
+

--- 1.41/storage/ndb/src/kernel/blocks/ERROR_codes.txt	2008-01-11 09:20:19 +01:00
+++ 1.42/storage/ndb/src/kernel/blocks/ERROR_codes.txt	2008-01-11 09:20:19 +01:00
@@ -11,7 +11,7 @@
 Next BACKUP 10038
 Next DBUTIL 11002
 Next DBTUX 12008
-Next SUMA 13034
+Next SUMA 13036
 
 TESTING NODE FAILURE, ARBITRATION
 ---------------------------------

--- 1.60/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2008-01-11 09:20:19 +01:00
+++ 1.61/storage/ndb/src/kernel/blocks/suma/Suma.cpp	2008-01-11 09:20:19 +01:00
@@ -4852,6 +4852,21 @@
     if(gci >= head.m_max_gci)
     {
       jam();
+      if (ERROR_INSERTED(13034))
+      {
+        jam();
+        SET_ERROR_INSERT_VALUE(13035);
+        return;
+      }
+      if (ERROR_INSERTED(13035))
+      {
+        CLEAR_ERROR_INSERT_VALUE;
+        NodeReceiverGroup rg(CMVMI, c_nodes_in_nodegroup_mask);
+        rg.m_nodes.clear(getOwnNodeId());
+        signal->theData[0] = 9999;
+        sendSignal(rg, GSN_NDB_TAMPER, signal, 1, JBA);
+        return;
+      }
       head.m_page_pos = 0;
       head.m_max_gci = gci;
       head.m_last_gci = 0;
@@ -4923,7 +4938,6 @@
 
   if(min > max)
   {
-    ndbrequire(pos.m_page_pos <= 2);
     ndbrequire(pos.m_page_id == bucket->m_buffer_tail);
     m_active_buckets.set(buck);
     m_gcp_complete_rep_count ++;

--- 1.28/storage/ndb/test/ndbapi/test_event.cpp	2008-01-11 09:20:19 +01:00
+++ 1.29/storage/ndb/test/ndbapi/test_event.cpp	2008-01-11 09:20:19 +01:00
@@ -1838,6 +1838,61 @@
   return NDBT_OK;
 }
 
+int 
+runBug33793(NDBT_Context* ctx, NDBT_Step* step)
+{
+  int result = NDBT_OK;
+  int loops = ctx->getNumLoops();
+
+  NdbRestarter restarter;
+  
+  if (restarter.getNumDbNodes() < 2){
+    ctx->stopTest();
+    return NDBT_OK;
+  }
+  // This should really wait for applier to start...10s is likely enough
+  NdbSleep_SecSleep(10);
+
+  while (loops-- && ctx->isTestStopped() == false)
+  {
+    int nodeId = restarter.getDbNodeId(rand() % restarter.getNumDbNodes());
+    int nodecount = 0;
+    int nodes[255];
+    printf("nodeid: %u : victims: ", nodeId);
+    for (int i = 0; i<restarter.getNumDbNodes(); i++)
+    {
+      int id = restarter.getDbNodeId(i);
+      if (id == nodeId)
+        continue;
+      
+      if (restarter.getNodeGroup(id) == restarter.getNodeGroup(nodeId))
+      {
+        nodes[nodecount++] = id;
+        printf("%u ", id);
+        int val2[] = { DumpStateOrd::CmvmiSetRestartOnErrorInsert, 1 };
+        if (restarter.dumpStateOneNode(id, val2, 2))
+          return NDBT_FAILED;
+      }
+    }
+    printf("\n"); fflush(stdout);
+
+    restarter.insertErrorInNode(nodeId, 13034);
+    if (restarter.waitNodesNoStart(nodes, nodecount))
+      return NDBT_FAILED;
+    
+    if (restarter.startNodes(nodes, nodecount))
+      return NDBT_FAILED;
+    
+    if (restarter.waitClusterStarted())
+      return NDBT_FAILED;
+  }
+
+  ctx->stopTest();  
+  return NDBT_OK;
+}
+
+
+
 NDBT_TESTSUITE(test_event);
 TESTCASE("BasicEventOperation", 
 	 "Verify that we can listen to Events"
@@ -1974,6 +2029,12 @@
   STEP(runBug31701);
   FINALIZER(runDropEvent);
   FINALIZER(runDropShadowTable);
+}
+TESTCASE("Bug33793", ""){
+  INITIALIZER(runCreateEvent);
+  STEP(runEventListenerUntilStopped);
+  STEP(runBug33793);
+  FINALIZER(runDropEvent);
 }
 NDBT_TESTSUITE_END(test_event);