List:Commits« Previous MessageNext Message »
From:uwendel Date:January 10 2008 2:33pm
Subject:PHP mysqlnd svn commit: r1205 - trunk/tests/ext/mysqli
View as plain text  
Author: uwendel
Date: 2008-01-10 15:33:06 +0100 (Thu, 10 Jan 2008)
New Revision: 1205

Modified:
   trunk/tests/ext/mysqli/mysqli_options.phpt
Log:
Adding discussion notes.



Modified: trunk/tests/ext/mysqli/mysqli_options.phpt
===================================================================
--- trunk/tests/ext/mysqli/mysqli_options.phpt	2008-01-10 14:09:50 UTC (rev 1204)
+++ trunk/tests/ext/mysqli/mysqli_options.phpt	2008-01-10 14:33:06 UTC (rev 1205)
@@ -16,14 +16,14 @@
 sense to have in PHP and not even sure which of them might be available
 already through other measures.
 
-	MYSQL_OPT_COMPRESS (argument: not used)
+	MYSQL_OPT_COMPRESS (argument: not used) --> Andrey/Ulf: bug, should be added
 	? MYSQL_OPT_NAMED_PIPE (argument: not used) ?
-	MYSQL_OPT_READ_TIMEOUT (argument type: unsigned int *)
-	MYSQL_OPT_RECONNECT (argument type: my_bool *)
-	MYSQL_OPT_SSL_VERIFY_SERVER_CERT (argument type: my_bool *)
-	MYSQL_OPT_WRITE_TIMEOUT (argument type: unsigned int *)
-	MYSQL_REPORT_DATA_TRUNCATION (argument type: my_bool *)
-	MYSQL_SECURE_AUTH (argument type: my_bool *)
+	MYSQL_OPT_READ_TIMEOUT (argument type: unsigned int *) --> Andrey/Ulf: bug, should be
added
+	MYSQL_OPT_RECONNECT (argument type: my_bool *) -->  Andrey/Ulf: might be security
risk to have
+	MYSQL_OPT_SSL_VERIFY_SERVER_CERT (argument type: my_bool *) --> Andrey/Ulf: might be
security risk to have
+	MYSQL_OPT_WRITE_TIMEOUT (argument type: unsigned int *) --> Andrey/Ulf: bug, should
be added
+	MYSQL_REPORT_DATA_TRUNCATION (argument type: my_bool *) --> Andrey: bug, although
truncation might only happen with libmysql not with mysqlnd
+	MYSQL_SECURE_AUTH (argument type: my_bool *) --> Ulf: let's say deprecated, no bug
 	? MYSQL_SET_CHARSET_DIR (argument type: char *) ?
 	MYSQL_SHARED_MEMORY_BASE_NAME (argument type: char *)
 */

Thread
PHP mysqlnd svn commit: r1205 - trunk/tests/ext/mysqliuwendel10 Jan