List:Commits« Previous MessageNext Message »
From:Georgi Kodinov Date:December 21 2007 10:21am
Subject:Re: bk commit into 5.0 tree (gkodinov:1.2591) BUG#33256
View as plain text  
Serg,

On 19.12.2007, at 14:54, Sergei Golubchik wrote:

> Hi!
>
> On Dec 18, kgeorge@stripped wrote:
>> ChangeSet@stripped, 2007-12-18 18:01:36+02:00, gkodinov@stripped +6  
>> -0
>>  Bug #33256: CREATE ... SELECT creates obsolete table
>>   w/ Field_date instead of Field_newdate
>>
>>  Field_date was still used in temp table creation.
>>  Fixed by using Field_newdate consistently throughout the server
>>  except when reading tables defined with older MySQL version.
>>  No test suite is possible because both Field_date and Field_newdate
>>  return the same values in all the metadata calls.
>
> one question, see below
>
>> diff -Nrup a/mysql-test/r/type_decimal.result b/mysql-test/r/ 
>> type_decimal.result
>> --- a/mysql-test/r/type_decimal.result	2007-10-29 13:39:54 +02:00
>> +++ b/mysql-test/r/type_decimal.result	2007-12-18 18:01:35 +02:00
>> @@ -786,10 +786,6 @@ from (select 1 as s,'t' as t union selec
>> select group_concat(t) from t1 group by week(date)/10;
>> group_concat(t)
>> t
>> -Warnings:
>> -Warning	1292	Truncated incorrect datetime value: '0000-00-00'
>> -Warning	1292	Truncated incorrect datetime value: '0000-00-00'
>> -Warning	1292	Truncated incorrect datetime value: '0000-00-00'
>
> one warning should still be issued, shouldn't it ?

IMHO no : there's no NO_ZERO_DATE/NO_ZERO_IN_DATE in effect. These  
warnings were bogus.

Best Regards,
Joro
-- 
Georgi Kodinov, Senior Software Engineer
MySQL AB, Plovdiv, Bulgaria, www.mysql.com
Office: +359 32 634 397 Mobile: +359 887 700 566 Skype: georgekodinov

Are you MySQL certified?  www.mysql.com/certification

Thread
bk commit into 5.0 tree (gkodinov:1.2591) BUG#33256kgeorge18 Dec
  • Re: bk commit into 5.0 tree (gkodinov:1.2591) BUG#33256Sergei Golubchik19 Dec
    • Re: bk commit into 5.0 tree (gkodinov:1.2591) BUG#33256Georgi Kodinov21 Dec
      • Re: bk commit into 5.0 tree (gkodinov:1.2591) BUG#33256Sergei Golubchik21 Dec