On Wed, Dec 19, 2007 at 01:24:50PM +0000, Jonathan Perkin wrote:
> diff -Nrup a/libmysqld/Makefile.am b/libmysqld/Makefile.am
> --- a/libmysqld/Makefile.am 2007-08-31 00:23:07 +01:00
> +++ b/libmysqld/Makefile.am 2007-12-19 10:26:20 +00:00
> @@ -21,13 +21,14 @@ MYSQLDATAdir = $(localstatedir)
> MYSQLSHAREdir = $(pkgdatadir)
> MYSQLBASEdir= $(prefix)
> MYSQLLIBdir= $(libdir)
> +pkgplugindir = $(libdir)/@PACKAGE@/plugin
Should this use $(pkglibdir) instead of $(libdir)/@PACKAGE@?
By the way, why is MYSQLLIBdir= $(libdir) here, but $(pkglibdir)
everywhere else?
> EXTRA_DIST = libmysqld.def CMakeLists.txt
> DEFS = -DEMBEDDED_LIBRARY -DMYSQL_SERVER \
> -DDEFAULT_MYSQL_HOME="\"$(MYSQLBASEdir)\"" \
> -DDATADIR="\"$(MYSQLDATAdir)\"" \
> -DSHAREDIR="\"$(MYSQLSHAREdir)\"" \
> - -DLIBDIR="\"$(MYSQLLIBdir)\""
> + -DPLUGINDIR="\"$(pkgplugindir)\""
Should LIBDIR be removed? why not keep it?
The rest looks fine. Probably you have good reasons for both of the
above, but I'm not certain I know them.
Ideally a lot of this stuff could be moved to an include file, I think.
But that is probably outside the scope of this bug fix.
Thanks,
Timothy
--
-- Timothy Smith Production Engineer; Dolores, Colorado, USA
-- MySQL, www.mysql.com The best DATABASE COMPANY in the GALAXY!
Attachment: [application/pgp-signature]
