List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:December 19 2007 12:12pm
Subject:Re: bk commit into 5.0 tree (gluh:1.2583) BUG#21317
View as plain text  
Hi!

On Dec 17, gluh@stripped wrote:
> ChangeSet@stripped, 2007-12-17 10:33:43+04:00, gluh@stripped +6 -0
>   Bug#21317 SHOW CREATE DATABASE does not obey to lower_case_table_names
>   preserve lettercase as it specified in 'show create'

Why would check_db_name() need NOT to preserve the name ?
Converting the name doesn't really fit into the concept of "checking".
check_db_name() is called in quite a few places, but would expect most
of them don't need the name to be converted (and some need it to be
preserved and work around this "feature").
 
> diff -Nrup a/sql/table.cc b/sql/table.cc
> --- a/sql/table.cc	2007-10-10 18:26:01 +05:00
> +++ b/sql/table.cc	2007-12-17 10:33:41 +04:00
> @@ -1613,13 +1613,13 @@ char *get_field(MEM_ROOT *mem, Field *fi
>      1   error
>  */
>  
> -bool check_db_name(char *name)
> +bool check_db_name(char *name, bool preserve_lettercase)

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.0 tree (gluh:1.2583) BUG#21317gluh17 Dec
  • Re: bk commit into 5.0 tree (gluh:1.2583) BUG#21317Sergei Golubchik19 Dec