List:Commits« Previous MessageNext Message »
From:Rafal Somla Date:December 13 2007 8:17am
Subject:Re: bk commit into 6.0 tree (rafal:1.2748) BUG#33119
View as plain text  
Lars Thalmann wrote:
> Hi Rafal, 
> 
> 1. "--exec cp" probably won't work on Windows?
> 2. Space in wrong place in "virtual bool is_valid() =0;"  :)
> 3. Also in "virtual result_t remove() =0;" :)
>

Hmm, why? Our coding guidelines doesn't say anything about spacing for pure 
virtual functions. Note that this is not variable assignment.

> Looks ok.  Ok to push after Chuck's review.
>

OK.

Rafal
Thread
bk commit into 6.0 tree (rafal:1.2748) BUG#33119rsomla12 Dec
  • RE: bk commit into 6.0 tree (rafal:1.2748) BUG#33119Chuck Bell13 Dec
    • Re: bk commit into 6.0 tree (rafal:1.2748) BUG#33119Rafal Somla13 Dec
      • RE: bk commit into 6.0 tree (rafal:1.2748) BUG#33119Chuck Bell13 Dec
        • Re: bk commit into 6.0 tree (rafal:1.2748) BUG#33119Rafal Somla13 Dec
          • RE: bk commit into 6.0 tree (rafal:1.2748) BUG#33119Chuck Bell13 Dec
Re: bk commit into 6.0 tree (rafal:1.2748) BUG#33119Rafal Somla13 Dec