Hi Sergey,
please accept my apologies for the late review. I simply forgot to do it.
Sergey Vojtovich, 04.12.2007 15:40:
...
> ChangeSet@stripped, 2007-12-04 18:40:12+04:00, svoj@stripped +1 -0
> BUG#22708 - Error message doesn't refer to storage engine unsupported
>
> When openning a table with unsupported (disabled or not compiled)
> storage engine, confusing error message is returned.
>
> Return better error message when we're attempting to open a table
> that uses unsupported engine.
...
> + else if (!tmp_plugin)
> + {
> + error= 8;
> + my_error(ER_UNKNOWN_STORAGE_ENGINE, MYF(0), name.str);
> + my_free(buff, MYF(0));
> + goto err;
> + }
I understand that the test suite cannot test this bug fix. But then I
would have expected some purecov comment. Please add them, if necessary.
Otherwise ok to push by me.
P.S. I would probably have reported the error in open_table_error()
after "case 8". So it could be reused for other functions but
open_binary_frm(). Currently this is not an issue, as no other function
can return 8, I believe. But one day we might have something like
open_text_frm() or similar.
Regards
Ingo
--
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140
