Re: bk commit into 5.1 tree (dkatz:1.2681) BUG#29993

[Marc Alff]

Hi Damien

damien@stripped wrote:
> Below is the list of changes that have just been committed into a local
> 5.1 repository of dkatz. When dkatz does a push these changes will
> be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
>
> ChangeSet@stripped, 2007-12-10 19:49:18-05:00, dkatz@stripped +1 -0
>   Bug #29993	Default value of log_output should be 'FILE', not 'TABLE'
>   
>   Ensure default logging is "file" logging.
>
>   sql/mysqld.cc@stripped, 2007-12-10 19:49:13-05:00, dkatz@stripped
> +2 -2
>     Bug #29993	Default value of log_output should be 'FILE', not 'TABLE'
>     
>     Ensure default logging is "file" logging.
>
> diff -Nrup a/sql/mysqld.cc b/sql/mysqld.cc
> --- a/sql/mysqld.cc	2007-11-28 11:08:25 -05:00
> +++ b/sql/mysqld.cc	2007-12-10 19:49:13 -05:00
> @@ -478,7 +478,7 @@ ulong thread_id=1L,current_pid;
>  ulong slow_launch_threads = 0, sync_binlog_period;
>  ulong expire_logs_days = 0;
>  ulong rpl_recovery_rank=0;
> -const char *log_output_str= "TABLE";
> +const char *log_output_str= "FILE";
>  
>  time_t server_start_time;
>  
> @@ -7483,7 +7483,7 @@ mysqld_get_one_option(int optid,
>    {
>      if (!argument || !argument[0])
>      {
> -      log_output_options= LOG_TABLE;
> +      log_output_options= LOG_FILE;
>        log_output_str= log_output_typelib.type_names[1];
>      }
>      else
>
>   
For testing, please make sure that:

./mysqld ---no-defaults --verbose --help | grep "log-output"
actually returns FILE

I don't know a good way to automate this in a mysqltest script,
so performing this test manually is ok.
Please document the test in the bug report.

OK to push.

Thanks,
Marc.