Rafal,
Test #7 was meant to show that the DDL blocker can allow more than 1 blocker
to run at the same time. That's all. If you think I should expand it to
including DDL operations then that's fine I can do that. I'm not sure what
it will give us but it is just rerunning tests I've done before.
I added conditional debug directives to jump around your code for allowing
only 1 backup to run at a time. See the changes. I did this so that I could
test running more than one blocker at a time.
I am not finished with the code yet as I still have to review the list of
DDLs that are blocked and make sure I get all of them that everyone needs.
If you can think of anything else I should add please let me know.
Chuck
> -----Original Message-----
> From: Rafal Somla [mailto:rsomla@stripped]
> Sent: Tuesday, December 11, 2007 8:57 AM
> To: cbell@stripped
> Cc: commits@stripped
> Subject: Re: bk commit into 6.0 tree (cbell:1.2748) BUG#33024
>
> Hi Chuck,
>
> I've noticed that you have changed the backup_ddl_blocker test. I don't
> like the
> change because in the new version no DDL operations are issued and thus
> it is
> not tested if they are blocked or not. Why this change?
>
> Note also that after my patch, the exclusive execution of only a single
> BACKUP/RESTORE operation at a time is achieved via a separate global
> mutex,
> independent from the DDL blocker.
>
> Rafal
>
> cbell@stripped wrote:
> > Below is the list of changes that have just been committed into a local
> > 6.0 repository of cbell. When cbell does a push these changes will
> > be propagated to the main repository and, within 24 hours after the
> > push, to the public repository.
> > For information on how to access the public repository
> > see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
> >
> > ChangeSet@stripped, 2007-12-10 19:45:45-05:00, cbell@mysql_cab_desk. +7 -0
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > This patch includes a refactored DDL blocker that hides the
> > condition booleans and implements the methods as a singleton class.
> >
> > mysql-test/r/backup_ddl_blocker.result@stripped, 2007-12-10 19:43:11-05:00,
> Chuck@mysql_cab_desk. +42 -0
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > New test results.
> >
> > mysql-test/t/backup_ddl_blocker.test@stripped, 2007-12-10 19:43:11-05:00,
> Chuck@mysql_cab_desk. +80 -0
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > Added test for testing multiple blockers.
> >
> > sql/backup/kernel.cc@stripped, 2007-12-10 19:43:14-05:00,
> Chuck@mysql_cab_desk. +9 -9
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > Changes made to call singleton.
> >
> > sql/ddl_blocker.cc@stripped, 2007-12-10 19:43:12-05:00,
> Chuck@mysql_cab_desk. +57 -11
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > Refactored DDL blocker using a singleton class.
> >
> > sql/ddl_blocker.h@stripped, 2007-12-10 19:43:12-05:00,
> Chuck@mysql_cab_desk. +110 -41
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > This patch changes the DDL blocker from APIs to a singleton class.
> >
> > sql/mysqld.cc@stripped, 2007-12-10 19:43:12-05:00, Chuck@mysql_cab_desk.
> +9 -17
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > Instantiate the singleton class.
> >
> > sql/sql_parse.cc@stripped, 2007-12-10 19:43:13-05:00,
> Chuck@mysql_cab_desk. +30 -28
> > BUG#33024 : DDL Blocker uses exposed variables
> >
> > Changes made to call singleton.
> >
>
>
> --
> MySQL Code Commits Mailing List
> For list archives: http://lists.mysql.com/commits
> To unsubscribe: http://lists.mysql.com/commits?unsub=1
