Re: bk commit into 5.1 tree (istruewing:1.2678) BUG#30273

[Ingo Strüwing]

Hi Dmitri,

thanks for the review. I'll follow your suggestions. I have just one
comment about pthread_mutex_destroy():

Dmitri Lenev, 11.12.2007 11:33:
...
> Since you are initializing this mutex here you should also destroy
> it somewhere... Please add call to pthread_mutex_destroy() to 
> appropriate place in code (probably to myrg_close()?).

Thanks for noticing this. It was an omission. I will add it. However I
wonder why neither safemalloc nor valgrind noticed it.

Also I detected during some experiments, that the embedded server does
not call mysqld.cc:clean_up_mutexes(). So the absolute necessity of
pthread_mutex_destroy() is at least arguable.

Regards
Ingo
-- 
Ingo Strüwing, Senior Software Developer
MySQL GmbH, Dachauer Str. 37, D-80335 München
Geschäftsführer: Kaj Arnö - HRB München 162140