Re: bk commit into 5.1 tree (kostja:1.2614) BUG#25535

[Sergei Golubchik]

Hi!

On Dec 07, Konstantin Osipov wrote:
> * Sergei Golubchik <serg@stripped> [07/12/07 23:22]:
> 
> > > > > > It basically is a part of the public library API - it's the
> > > > > > only way for a client to support /etc/my.cnf configuration,
> > > > > > which is supposed to be common to all clients.
> > 
> > > load_defaults is not a documented part of the client library API.
> > > Are you suggesting it is added to the manual?
> > 
> > Perhaps, yes.
> > 
> > But a google search reveals quite a few references to
> > load_defaults():
> > 
> > http://www.jsw4.net/info/listserv_archives/mysql/05-wk02/msg00115.html
> > http://www.listsearch.com/MySQL/Message/index.lasso?216520
> > http://www.searchy.net/mailinglists/MySQL_General/msg11412.html
> > http://www.galileo-press.de/openbook/c_von_a_bis_z/c_027_003.htm
> > http://search.cpan.org/~darren/MySQL-Config-1.03/lib/MySQL/Config.pm
> > (the last is the pupe-perl emulation, shows that the functionality is
> > used indeed)
> 
> Serg, the path of least resistance is to assume all these users of
> load_defaults were doing the right thing and thus put it back.

For me, the path of least resistance would be to agree with you and let
load_defaults() to stay in my_sys.h :)
 
> There is no single reason load_defaults should belong to connector/C,
> except that it was there already.

That's what Paul and I are trying to explain: the reason is that
load_defaults() and my_getopt.h belong to a basic functionality, which
every client should use (at least, should be able to).
 
> I don't care as much about the matter as I care to understand your
> logic, and it does not look very logical (well, maybe yet).

I'm considering load_defaults() an important part of the API, that's
what the logic is based on. I wouldn't argue that way for any arbitrary
function in my_sys.h, not for modify_defaults(), for example, that was
also removed from mysql_com.h in the same changeset.
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140