Hi Kristofer,
Approved with a minor comment.
kpettersson@stripped wrote:
[..]
> +#
> +# Bug #30887 Server crashes on SET GLOBAL query_cache_size=0
> +#
> +flush status;
> +set query_cache_type=DEMAND;
> +set global query_cache_size= 1024*1024*512;
> +--disable_warnings
> +drop table if exists t1;
> +--enable_warnings
> +create table t1 (a varchar(100));
> +insert into t1 values ('..'),('..');
> +connect (bug30887con1, localhost, root, ,test);
> +connect (bug30887con2, localhost, root, ,test);
> +
> +connection bug30887con1;
> +--echo Activate debug hook and attempt to retrieve the statement from the cache.
> +set session debug='+d,wait_in_query_cache_insert';
[..]
> +disconnect bug30887con1;
> +disconnect bug30887con2;
> +use test;
> +drop table t1;
I think we need to "restore" the debug session here so that it won't
interfere with future tests on this file.
Good work, thanks!
--
Davi Arnaut, Software Engineer
MySQL Inc, www.mysql.com
Are you MySQL certified? www.mysql.com/certification
