Re: bk commit into 5.1 tree (kostja:1.2614) BUG#25535

[Sergei Golubchik]

Hi!

On Dec 04, konstantin@stripped wrote:
> ChangeSet@stripped, 2007-12-04 22:32:08+03:00, kostja@bodhi.(none) +1 -0
>   Fix Bug#25535 "load_defaults() no longer included by mysql.h" by
>   making sure that load_defaults can be made available by including
>   my_sys.h. Note, if one includes both my_sys.h and mysql.h, my_sys.h
>   got to go first (this is how mysql.h is written).

I don't like it. my_sys.h and my_global.h always were internal headers,
we modify them at will without a second thought. They define lots of
types and macros that are used in MySQL sources but make no sense
anywhere else (example: my_global.h starts from defining
INNODB_COMPATIBILITY_HOOKS). They aren't appropriate to be declared a
public client API.

Why not to add/move load_defaults() to mysql.h where it was ?
 
> diff -Nrup a/include/my_sys.h b/include/my_sys.h
> --- a/include/my_sys.h	2007-10-02 11:32:29 +04:00
> +++ b/include/my_sys.h	2007-12-04 22:32:03 +03:00
> @@ -15,6 +15,11 @@
>  
>  #ifndef _my_sys_h
>  #define _my_sys_h
> +/*
> +  Include my_global.h so that my_sys.h can stand as an independent
> +  public header of mysys library
> +*/
> +#include <my_global.h>
>  C_MODE_START
>  
>  #ifdef HAVE_AIOWAIT
> 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140