Hi!
On Dec 03, Sergei Golubchik wrote:
> On Nov 29, antony@stripped wrote:
> > ChangeSet@stripped, 2007-11-29 14:40:36-08:00, acurtis@stripped +34 -0
> > WL#3771 - Plugable Audit Interface
> > First commit for review
> > Have run default tests with/without plugin:
> > mysql-test-run.pl --mysqld=--plugin-dir=<path to plugin>
> > --mysqld=--plugin-load=adt_null.so
>
> > include/Makefile.am@stripped, 2007-11-29 14:40:15-08:00, acurtis@stripped +2 -1
> > add new source files: mysql/ftparser.h mysql/audit.h
>
> in wl#4017 patch (query rewrite plugin) BrianM also had a new file for
> the rewrite plugin.
Looking at wl#4017 patch again, I've noticed it has a lot of changes to
CMakeLists.txt. Please make sure you audit plugin builds on windows and
that tests pass there as well. You probably skipped that part, as it's
only a "first commit for review" - it's ok, but don't forget to fix it
in the final patch. Just a friendly reminder :)
Regards / Mit vielen Grüssen,
Sergei
--
__ ___ ___ ____ __
/ |/ /_ __/ __/ __ \/ / Sergei Golubchik <serg@stripped>
/ /|_/ / // /\ \/ /_/ / /__ Principal Software Developer
/_/ /_/\_, /___/\___\_\___/ MySQL GmbH, Dachauer Str. 37, D-80335 München
<___/ Geschäftsführer: Kaj Arnö - HRB
München 162140
