List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:December 1 2007 7:26pm
Subject:Re: bk commit into 5.1 tree (tnurnberg:1.2616) BUG#31177
View as plain text  
Hi!

On Dec 01, Tatjana A Nuernberg wrote:
> ChangeSet@stripped, 2007-12-01 19:55:06+01:00, tnurnberg@stripped +8 -0
>   Bug#31177: Server variables can't be set to their current values
>   
>   5.1+ specific fixes (plugins etc.)
> 
>   include/my_getopt.h@stripped, 2007-12-01 19:55:04+01:00, tnurnberg@stripped +2 -1
>     make both ull and ll global
> 
>   mysys/my_getopt.c@stripped, 2007-12-01 19:55:04+01:00, tnurnberg@stripped +35 -13
>     export getopt_ll_limit_value(), check for integer wrap-around
>     in it, same as in ull variant.  Only print warnings to reporter
>     when caller didn't ask for diagnostics, otherwise assume caller
>     will handle any warnings (id est, throw them client-wards)
> 
>   sql/mysqld.cc@stripped, 2007-12-01 19:55:04+01:00, tnurnberg@stripped +1 -1
>     correct signedness of "concurrent-insert"
> 
>   sql/sql_plugin.cc@stripped, 2007-12-01 19:55:04+01:00, tnurnberg@stripped +31 -4
>     Throw sys-var out-of-range warnings client-wards for
>     plugins, too.
> 
> diff -Nrup a/mysql-test/r/innodb.result b/mysql-test/r/innodb.result
> --- a/mysql-test/r/innodb.result	2007-11-30 14:52:49 +01:00
> +++ b/mysql-test/r/innodb.result	2007-12-01 19:55:04 +01:00
> @@ -1793,7 +1793,7 @@ Variable_name	Value
>  innodb_thread_concurrency	8
>  set global innodb_thread_concurrency=1001;
>  Warnings:
> -Warning	1292	Truncated incorrect innodb_thread_concurrency value: '1001'
> +Warning	1292	Truncated incorrect thread_concurrency value: '1001'

This is not very good.
Please keep the warning as it was - with the full variable name.

Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.1 tree (tnurnberg:1.2616) BUG#31177Tatjana A Nuernberg1 Dec
  • Re: bk commit into 5.1 tree (tnurnberg:1.2616) BUG#31177Sergei Golubchik1 Dec