List:Commits« Previous MessageNext Message »
From:Sergei Golubchik Date:November 30 2007 4:09pm
Subject:Re: bk commit into 5.1 tree (anozdrin:1.2673) BUG#31947
View as plain text  
Hi!

On Nov 30, Alexander Nozdrin wrote:
> ChangeSet@stripped, 2007-11-30 17:31:26+03:00, anozdrin@ibm. +3 -0
>   A patch for BUG#31947: Declare with a reserved word succeeded.
>   
>   The problem here was that "read_only" was explicitly allowed
>   as an indentifier. Probably that was done in order to allow
>   "read_only" system variable name.
>   
>   The fix is to change parsing rules so that "read_only" can not
>   be used as an identifier, but allowed as a system variable name.

<cut 156 lines>

Eh ? We have two lists for keywords that can be used as identifiers -
'keyword' and 'keyword_sp'. Apparently, when READ_ONLY was added as a
symbol it was mistakenly added to 'ident' rule instead of 'keyword_sp'
rule. And the fix obviously is to move it where it belongs.
 
Regards / Mit vielen Grüssen,
Sergei

-- 
   __  ___     ___ ____  __
  /  |/  /_ __/ __/ __ \/ /   Sergei Golubchik <serg@stripped>
 / /|_/ / // /\ \/ /_/ / /__  Principal Software Developer
/_/  /_/\_, /___/\___\_\___/  MySQL GmbH, Dachauer Str. 37, D-80335 München
       <___/                  Geschäftsführer: Kaj Arnö - HRB
München 162140
Thread
bk commit into 5.1 tree (anozdrin:1.2673) BUG#31947Alexander Nozdrin30 Nov
  • Re: bk commit into 5.1 tree (anozdrin:1.2673) BUG#31947Sergei Golubchik30 Nov