Hi Andrei!
Patch is OK to push. I see nothing that will cause problems with the server.
I leave to Lars (he's the second reviewer) to decide on our disagreement
regarding the return value of the bit functions and where and when check it.
Just my few cents,
Mats Kindahl
Andrei Elkin wrote:
> Below is the list of changes that have just been committed into a local
> 5.1 repository of elkin. When elkin does a push these changes will
> be propagated to the main repository and, within 24 hours after the
> push, to the public repository.
> For information on how to access the public repository
> see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html
>
> ChangeSet@stripped, 2007-11-30 13:49:33+02:00, aelkin@stripped +35 -0
> Bug#31552 Replication breaks when deleting rows from out-of-sync table
> without PK
> Bug#31609 Not all RBR slave errors reported as errors
> bug#32468 delete rows event on a table with foreign key constraint fails
>
> The first two bugs comprise idemptency issues.
>
Typo: idemptency
> First, there was no error code reported under conditions of the bug
> description although the slave sql thread halted.
> Second, executions were different with and without presence of prim key in
> the table.
> Third, there was no way to instruct the slave whether to ignore an error
> and skip to the following event or to halt.
> Fourth, there are handler errors which might happen due to idempotant
>
Typo: idempotant
[snip]
> mysql-test/suite/rpl_ndb/t/rpl_ndb_dd_advance.test@stripped, 2007-11-30 13:49:25+02:00,
> aelkin@stripped +3 -0
> changes due to bug#31552/31609 idemptency is not default any longer
>
Typo: idemptency
[snip]
> sql/sql_class.h@stripped, 2007-11-30 13:49:27+02:00, aelkin@stripped +3 -0
> The names for the bits of the new sever slave_exec_mode_options.
>
Typo: sever (I assume)
> diff -Nrup a/include/my_bitmap.h b/include/my_bitmap.h
> --- a/include/my_bitmap.h 2007-07-25 16:29:28 +03:00
> +++ b/include/my_bitmap.h 2007-11-30 13:49:21 +02:00
> @@ -159,6 +159,22 @@ static inline my_bool bitmap_cmp(const M
> #define bitmap_set_all(MAP) \
> (memset((MAP)->bitmap, 0xFF, 4*no_words_in_map((MAP))))
>
> +/**
> + check, set and clear a bit of interest of an integer.
> +
> + If the bit is out of range @retval -1. Otherwise
> + bit_is_set @return 0 or 1 reflecting the bit is set or not;
> + bit_do_set @return 1 (bit is set 1)
> + bit_do_clear @return 0 (bit is cleared to 0)
> +*/
> +
> +#define bit_is_set(I,B) (sizeof(I) * CHAR_BIT > (B) ? \
> + (((I) & (ULL(1) << (B))) == 0 ? 0 : 1) : -1)
> +#define bit_do_set(I,B) (sizeof(I) * CHAR_BIT > (B) ? \
> + ((I) |= (ULL(1) << (B)), 1) : -1)
> +#define bit_do_clear(I,B) (sizeof(I) * CHAR_BIT > (B) ? \
> + ((I) &= ~(ULL(1) << (B)), 0) : -1)
> +
> #ifdef __cplusplus
> }
> #endif
>
--
Mats Kindahl
Lead Software Developer
Replication Team
MySQL AB, www.mysql.com
