List:Commits« Previous MessageNext Message »
From:Sergey Vojtovich Date:November 30 2007 11:00am
Subject:bk commit into 5.1 tree (svoj:1.2673) BUG#32050
View as plain text  
Below is the list of changes that have just been committed into a local
5.1 repository of svoj. When svoj does a push these changes will
be propagated to the main repository and, within 24 hours after the
push, to the public repository.
For information on how to access the public repository
see http://dev.mysql.com/doc/mysql/en/installing-source-tree.html

ChangeSet@stripped, 2007-11-30 15:00:15+04:00, svoj@stripped +1 -0
  BUG#32050 - table logging gone wrong.
  
  Reverted log tables alteration.

  scripts/mysql_system_tables_fix.sql@stripped, 2007-11-30 15:00:10+04:00, svoj@stripped +0 -16
    Altering log table is wrong, because
    - it is not possible to alter log table when it is in use;
    - log table may use MyISAM engine, which perfectly supports NULLs.
    
    Reverted log tables alteration.

diff -Nrup a/scripts/mysql_system_tables_fix.sql b/scripts/mysql_system_tables_fix.sql
--- a/scripts/mysql_system_tables_fix.sql	2007-11-27 14:01:02 +04:00
+++ b/scripts/mysql_system_tables_fix.sql	2007-11-30 15:00:10 +04:00
@@ -513,22 +513,6 @@ ALTER TABLE tables_priv MODIFY Table_pri
 
 UPDATE user SET Trigger_priv=Super_priv WHERE @hadTriggerPriv = 0;
 
-#
-# Log Table
-#
-
-ALTER TABLE general_log 
-  MODIFY COLUMN user_host MEDIUMTEXT NOT NULL,
-  MODIFY COLUMN thread_id INTEGER NOT NULL,
-  MODIFY COLUMN server_id INTEGER NOT NULL,
-  MODIFY COLUMN command_type VARCHAR(64) NOT NULL,
-  MODIFY COLUMN argument MEDIUMTEXT NOT NULL;
-ALTER TABLE slow_log
-  MODIFY COLUMN db VARCHAR(512) NOT NULL,
-  MODIFY COLUMN last_insert_id INTEGER NOT NULL,
-  MODIFY COLUMN insert_id INTEGER NOT NULL,
-  MODIFY COLUMN server_id INTEGER NOT NULL;
-
 # Activate the new, possible modified privilege tables
 # This should not be needed, but gives us some extra testing that the above
 # changes was correct
Thread
bk commit into 5.1 tree (svoj:1.2673) BUG#32050Sergey Vojtovich30 Nov