Rafal,
My responses...
> Chuk,
Never been called that before... ;) Have you heard the saying, "I've been
called worse by better people."? Is there something like that in Polish?
> 1. First I'll modify my patches to take into account all
> changes not related to the merge. I'll send replies to your
> review emails for each patch describing what I'm going to do.
ok
> 2. Then I'll do the merge and send you a separate merge patch, which
> (unfortunately) will be incremental, i.e. to be applied over
> the previous patches.
>
> Hope this is ok.
yes
> > 1) ensure meta_backup.cc and sql_backup.cc files get removed
>
> I think leaving renamed files in place is a feature of bk. If
> I clone my repository, the old files are not present any more.
I suspected as much.
> > 2) repair the data_backup.cc file to replace the ddl
> blocker and fkey
> > code
>
> I'll do that when I merge with current tree.
Ok
> > 3) fix the Windows compilation errors/warnings in stream_v1.c
> >
>
> I'll do that in the patch for backup stream library (the second patch)
>
> BTW. Could you do this experiment for me: remove any
> definitions/declarations of
> bzero() functions in stream_v1* files and replace them/it by
>
> #define bzero(A,B) memset((A),0,(B))
>
> Then see if it will compile without a warning. Thanks!
It compiles with the same warnings and errors. The only one that works (on
Windows) is:
# define bzero(A,B) memset((A),0,(B))
Chuck
