Sergei Golubchik <serg@stripped> writes:
> good. just one question:
> you can have signed variables (GET_INT, GET_LONG, GET_LL) in
> getopt_ull_limit_value() ?
Yes, isn't it fun. ;-/ We're fine as far as command-line options are
concerned (now that I've corrected the GET_* for innobase to their
actual types), but you'll notice that we declare ull globally, but
not ll. Which is because we only use ull in set_var. Nevertheless,
we have variables like "concurrent-insert" which are eligible for
SET, are signed, but go through "unsigned" (or rather, "we only care
for length, not signedness") in set-var. Thanks to the extra code,
that can no longer give rise to bugs, but I'm the first to agree
that it isn't as pretty as it could be. May be worthwhile to write
a ticket "check whether signed server-variables actually need to be
signed, and if so, create a new signed sys-var type for them."
regards,
Tatjana
--
Tatjana A. Nurnberg, Bugs Bunny * MySQL AB, http://www.mysql.de/ * EST
IRC: Azundris * Skype: azundris * MySQL-SIP: 4550 * eMail: azundris@stripped
.de: Firmensitz: MySQL GmbH, Radlkoferstr. 2, D-81373 Muenchen
Geschaeftsfuehrer: Hans von Bell, Kaj Arnoe - HRB Muenchen 162140
