Re: bk commit into 5.1 tree (kostja:1.2607) BUG#12713

[Konstantin Osipov]

* Sergei Golubchik <serg@stripped> [07/11/20 18:59]:
> > ChangeSet@stripped, 2007-11-14 17:46:40+03:00, kostja@bodhi.(none) +9 -0
> >   Bug#12713. This patch fixes the bug. No test cases, changeset comments, 
> >   or review comments.
> >   An intermediate commit for the passing test suite.
> 
> I've only looked at handler.cc, handler.h, and sql_class.h changes.
> They looked ok to me.
> 
> The rest was, apparently, not related to commit/rollback changes, but
> consisted of fixes for your earlier changesets.
> 
> see a couple of suggestions below, mostly about comments - what they
> could clarify better.

Hello Serg,

Thank you for this review. I will address your comments tomorrow.

Meanwhile I committed the patch that adds some tests and
implements transaction-wide optimisation.

http://lists.mysql.com/commits/38320


-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY