List:Commits« Previous MessageNext Message »
From:Mattias Jonsson Date:November 22 2007 1:58pm
Subject:Re: bk commit into 5.1 tree (ramil:1.2627) BUG#29258
View as plain text  
Hi Ramil,


I have some improvements to your patch that fixes the rest of the 
earlier mentioned problems. If you include them in your patch and update 
the test case, you are OK to push!

Please close the bug#32566 as a duplicate of this (bug#29258)

Regards,
Mattias


I earlier wrote:
The patch is OK, it works for the selects with WHERE now.

But I have done some more testing on the corner cases (see attached test
and result files) that shows some minor problems (should at least be
documented). I will discuss these with Mikael on Thursday, before we
approve the patch for pushing.

The problems are:
- Can still insert maximum value if numeric maximum value is the last
range. (should only work if LESS THAN MAXVALUE)
- Cannot have both numeric maximum value and MAXVALUE string as ranges
(Same value, but different meaning)

... <removed some> ...

-- 
Mattias Jonsson, Software Engineer
MySQL AB, www.mysql.com

Are you MySQL certified?  www.mysql.com/certification


Attachment: [application/x-gzip] bug29258.extra.tgz
Thread
bk commit into 5.1 tree (ramil:1.2627) BUG#29258ramil21 Nov
  • Re: bk commit into 5.1 tree (ramil:1.2627) BUG#29258Mattias Jonsson21 Nov
  • Re: bk commit into 5.1 tree (ramil:1.2627) BUG#29258Mattias Jonsson22 Nov