Re: bk commit into 6.0 tree (msvensson:1.2655) BUG#31952

[Magnus Svensson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Konstantin Osipov wrote:
> * msvensson@stripped <msvensson@stripped> [07/11/16 13:39]:
> 
>> ChangeSet@stripped, 2007-11-16 11:25:54+01:00, msvensson@stripped +5 -0
>>   Bug#31952 Remove undocumented mysql_rpl_* functions.
>>    - Functions removed + variables in st_mysql and st_mysql_options renamed
>>      to "unusedn".
>>    - Code updated to work without those functions and variables 
> 
> OK to push.
>> @@ -6890,9 +6852,9 @@ int main(int argc, char **argv)
>>        case Q_DISCONNECT:
>>        case Q_DIRTY_CLOSE:
>>  	do_close_connection(command); break;
>> -      case Q_RPL_PROBE: do_rpl_probe(command); break;
>> -      case Q_ENABLE_RPL_PARSE:	 do_enable_rpl_parse(command); break;
>> -      case Q_DISABLE_RPL_PARSE:  do_disable_rpl_parse(command); break;
>> +      case Q_RPL_PROBE:          deprecated(command); break;
>> +      case Q_ENABLE_RPL_PARSE:	 deprecated(command); break;
>> +      case Q_DISABLE_RPL_PARSE:  deprecated(command); break;
> 
> I assume you will clean up the test suite in a different change
> set.
> 
> I see no reason any trace of mysql_rpl_* should be left anywhere
> in the code.

How do you mean? Remove also the commands totally? Or do you just want a
different changeset for the deprecation?

> 
> Please make sure to update the ABI file with your changes.
>

It's not yet update in 6.0 - it's not running.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFHQp6iVo+tSGMPTooRAu2KAJ9MKP9UgsD2EXdbvz33eo32jKe6QwCeM4y5
76ILDO5RfYeo8xH+8mBQgew=
=xBFn
-----END PGP SIGNATURE-----