List:Commits« Previous MessageNext Message »
From:Konstantin Osipov Date:November 19 2007 2:19pm
Subject:Re: bk commit into 6.0 tree (msvensson:1.2655) BUG#31952
View as plain text  
* msvensson@stripped <msvensson@stripped> [07/11/16 13:39]:

> ChangeSet@stripped, 2007-11-16 11:25:54+01:00, msvensson@stripped +5 -0
>   Bug#31952 Remove undocumented mysql_rpl_* functions.
>    - Functions removed + variables in st_mysql and st_mysql_options renamed
>      to "unusedn".
>    - Code updated to work without those functions and variables 

OK to push.
> @@ -6890,9 +6852,9 @@ int main(int argc, char **argv)
>        case Q_DISCONNECT:
>        case Q_DIRTY_CLOSE:
>  	do_close_connection(command); break;
> -      case Q_RPL_PROBE: do_rpl_probe(command); break;
> -      case Q_ENABLE_RPL_PARSE:	 do_enable_rpl_parse(command); break;
> -      case Q_DISABLE_RPL_PARSE:  do_disable_rpl_parse(command); break;
> +      case Q_RPL_PROBE:          deprecated(command); break;
> +      case Q_ENABLE_RPL_PARSE:	 deprecated(command); break;
> +      case Q_DISABLE_RPL_PARSE:  deprecated(command); break;

I assume you will clean up the test suite in a different change
set.

I see no reason any trace of mysql_rpl_* should be left anywhere
in the code.

Please make sure to update the ABI file with your changes.

-- 
-- Konstantin Osipov              Software Developer, Moscow, Russia
-- MySQL AB, www.mysql.com   The best DATABASE COMPANY in the GALAXY
Thread
bk commit into 6.0 tree (msvensson:1.2655) BUG#31952msvensson16 Nov
  • Re: bk commit into 6.0 tree (msvensson:1.2655) BUG#31952Konstantin Osipov19 Nov
    • Re: bk commit into 6.0 tree (msvensson:1.2655) BUG#31952Magnus Svensson20 Nov
      • Re: bk commit into 6.0 tree (msvensson:1.2655) BUG#31952Konstantin Osipov20 Nov